Update `llzk-pod-to-scalar` to split pods within arrays to multiple arrays by tim-hoffman · Pull Request #565 · project-llzk/llzk-lib

tim-hoffman · 2026-06-18T22:55:23Z

No description provided.

github-actions · 2026-06-18T22:57:30Z

Test Results

2 files + 1 2 suites +1 7m 36s ⏱️ + 2m 44s
330 tests + 15 326 ✅ + 15 4 💤 ±0 0 ❌ ±0
660 runs +345 652 ✅ +341 8 💤 +4 0 ❌ ±0

Results for commit 2055a67. ± Comparison against base commit 08360a9.

♻️ This comment has been updated with latest results.

tim-hoffman · 2026-06-18T23:19:52Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 477c5322c0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

tim-hoffman · 2026-06-23T21:05:47Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 45632675f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

tim-hoffman · 2026-07-13T17:35:02Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e8722c1ed4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

tim-hoffman · 2026-07-14T01:35:31Z

@codex review

chatgpt-codex-connector · 2026-07-14T01:42:46Z

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 04f30bd9b6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

0xddom

The PodToScalarPass.cpp file is helper functions galore. The code is hard to follow and I think it could be organized a bit better.

0xddom · 2026-07-14T11:42:29Z

+// CHECK-SAME:         %[[ARR_X:[0-9a-zA-Z_\.]+]]: !array.type<2 x index>,
+// CHECK-SAME:         %[[ARR_Y:[0-9a-zA-Z_\.]+]]: !array.type<2 x !felt.type>,
+// CHECK-SAME:         %[[ELEM:[0-9a-zA-Z_\.]+]]: !poly.tvar<@E>) attributes {function.allow_constraint} {
+// CHECK-NEXT:        %[[ELEM_LEAVES:[0-9a-zA-Z_\.]+]]:2 = builtin.unrealized_conversion_cast %[[ELEM]] : !poly.tvar<@E> to index, !felt.type


I'm not sure if this cast can be easily reconciled without special handling since it goes 1:2 in terms of values. What happens if we feed this IR to the flattening pass?

Oh, it seems I missed several unrealized_conversion_cast that were left behind and should be handled (if possible).

It's fine to leave some unrealized conversions if passes down the line can clear them up

0xddom · 2026-07-14T11:50:23Z

+// CHECK-NEXT:        %[[VAL_4:[0-9a-zA-Z_\.]+]] = poly.unifiable_cast %[[VAL_0]] : (!array.type<2,? x !poly.tvar<@T>>) -> !array.type<2,? x index>
+// CHECK-NEXT:        %[[VAL_5:[0-9a-zA-Z_\.]+]] = poly.unifiable_cast %[[VAL_0]] : (!array.type<2,? x !poly.tvar<@T>>) -> !array.type<2,? x !felt.type>
+// CHECK-NEXT:        %[[VAL_6:[0-9a-zA-Z_\.]+]] = poly.unifiable_cast %[[VAL_0]] : (!array.type<2,? x !poly.tvar<@T>>) -> !array.type<2,? x none>


This cast feel wrong when compared to the others

Yep. I thought I fixed that.

0xddom · 2026-07-14T11:53:26Z

+// CHECK-LABEL: module attributes {llzk.lang} {
+// CHECK-NEXT:    function.def @named_array_result
+// CHECK-SAME:    (%[[VAL_0:[0-9a-zA-Z_\.]+]]: !array.type<2 x index>, %[[VAL_1:[0-9a-zA-Z_\.]+]]: !array.type<2 x !felt.type>)
+// CHECK-SAME:    -> (!array.type<2 x index> {function.res_name = "out.lhs"}, !array.type<2 x !felt.type> {function.res_name = "out.rhs"}) {


This may cause issues in llzk-spec since out.lhs is not a valid identifier. I'm not sure what the best solution would be. @iangneal thoughts?

0xddom · 2026-07-14T12:53:38Z

+      SplitPodArrayNonDetOp, SplitPodArrayCreateArrayOp, SplitPodArrayReadArrayOp,
+      SplitPodArrayWriteArrayOp, SplitPodArrayExtractArrayOp, SplitPodArrayInsertArrayOp,
+      SplitPodArrayInFuncDefOp, SplitPodArrayInReturnOp, SplitPodArrayInCallOp,
+      SplitPodArrayInEmitEqualityOp, SplitPodArrayInEmitContainmentOp, SplitPodArrayLengthOp>(


I think instead of handling those we should lower them into loops with another pass that should be called before this one if necessary.

0xddom · 2026-07-15T10:40:08Z

+// CHECK-SAME:         %[[ARR_X:[0-9a-zA-Z_\.]+]]: !array.type<2 x index>,
+// CHECK-SAME:         %[[ARR_Y:[0-9a-zA-Z_\.]+]]: !array.type<2 x !felt.type>,
+// CHECK-SAME:         %[[ELEM:[0-9a-zA-Z_\.]+]]: !poly.tvar<@E>) attributes {function.allow_constraint} {
+// CHECK-NEXT:        %[[ELEM_LEAVES:[0-9a-zA-Z_\.]+]]:2 = builtin.unrealized_conversion_cast %[[ELEM]] : !poly.tvar<@E> to index, !felt.type


It's fine to leave some unrealized conversions if passes down the line can clear them up

tim-hoffman added 3 commits June 18, 2026 16:40

changelog

d659eaf

add test case

d256d32

split pods within arrays to multiple arrays

f6e898e

tim-hoffman requested a review from a team as a code owner June 18, 2026 22:55

Merge branch 'main' into th/make_pod_to_scalar_split_arrays

cdf8853

tim-hoffman added 2 commits June 18, 2026 18:01

fix compile error from merge

6793d6e

fix shadowing warnings

477c532

reverse pipeline ordering based on this update

3d01279

tim-hoffman mentioned this pull request Jun 18, 2026

verif to smt conversion #549

Draft

chatgpt-codex-connector Bot reviewed Jun 18, 2026

View reviewed changes

iangneal previously requested changes Jun 19, 2026

View reviewed changes

Comment thread lib/Dialect/POD/Transforms/PodToScalarPass.cpp Outdated

Comment thread lib/Dialect/POD/Transforms/PodToScalarPass.cpp Outdated

Comment thread lib/Dialect/POD/Transforms/PodToScalarPass.cpp Outdated

Comment thread lib/Dialect/POD/Transforms/PodToScalarPass.cpp Outdated

tim-hoffman added 12 commits June 22, 2026 09:55

clarify documentation

e9a3bb2

fix: Convert subarray ops for POD arrays

6fb0125

Merge branch 'main' into th/make_pod_to_scalar_split_arrays

87a5fcd

update test to ensure distinct types are preserved

fd339e7

fix: avoid invalid member ref and fully handle array of pod

bc05e5f

fix: Avoid assuming one backing array for array.len

3166d45

fix: Populate result split sizes before cloning attrs

2d0db69

Merge branch 'main' into th/make_pod_to_scalar_split_arrays

233a887

fix: split equality constraints over POD arrays

e516171

fix: Avoid creating arrays whose elements are arrays

c5d0d62

fix dangling ref

34bd6e0

additional regression test

4563267

tim-hoffman requested review from a team and iangneal June 23, 2026 21:10

chatgpt-codex-connector Bot reviewed Jun 23, 2026

View reviewed changes

clang-tidy cleanup

fae7959

tim-hoffman removed request for a team and iangneal July 13, 2026 15:22

Merge branch 'main' into th/make_pod_to_scalar_split_arrays

7da8b54

tim-hoffman force-pushed the th/make_pod_to_scalar_split_arrays branch from 7b9bf28 to 7da8b54 Compare July 13, 2026 16:15

tim-hoffman added 3 commits July 13, 2026 12:01

fix some issues that show up post-merge

76631bd

remove code duplication

67a2a71

refactor step 3 to clean it up a bit

e8722c1

fix shadowing warnings

5a2db39

chatgpt-codex-connector Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread lib/Dialect/POD/Transforms/PodToScalarPass.cpp

Comment thread lib/Dialect/POD/Transforms/PodToScalarPass.cpp Outdated

Comment thread lib/Dialect/POD/Transforms/PodToScalarPass.cpp Outdated

tim-hoffman added 2 commits July 13, 2026 15:48

fix: Handle generic lhs arrays in POD-array containment

2733b60

fix: Populate shape carriers for dynamic quantifier iterands

04f30bd

tim-hoffman requested a review from a team July 14, 2026 01:43

0xddom requested changes Jul 14, 2026

View reviewed changes

tim-hoffman added 11 commits July 14, 2026 09:49

add test with member name collision

c7f3394

remove useless function

7e88387

replace functions with constants

48a3e72

remove redundant cast

a81ebd1

use type alias more widely

fe546cf

assorted minor changes

98e7739

document "virtual pod"

a844984

move some functions to RecordChain

1c37e06

add ArrayType::getSelectionType() to remove some duplication

adb864c

reorg function defs

1ea5c95

add -verify-diagnostics to more tests just to be safe

1466aae

0xddom reviewed Jul 15, 2026

View reviewed changes

tim-hoffman added 2 commits July 15, 2026 09:16

update documentation

df0e8b9

make array read/write gen helpers reusable

2055a67

Uh oh!

Conversation

tim-hoffman commented Jun 18, 2026

Uh oh!

github-actions Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

tim-hoffman commented Jun 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tim-hoffman commented Jun 23, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tim-hoffman commented Jul 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tim-hoffman commented Jul 14, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 14, 2026

Uh oh!

0xddom left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

github-actions Bot commented Jun 18, 2026 •

edited

Loading